PR Review Methodology

Why Multi-Role Review?

Single-perspective code reviews miss things. By simulating multiple roles during review, you get a much more complete assessment of the change's quality and impact.

Review Roles

1. Product Manager Review

Look at the change from a product angle:

• Business Value: Does this deliver promised value?
• User Experience: Will users benefit from this change?
• Strategic Alignment: Does it align with product goals?
• Feature Completeness: Are all requirements met?
• Action: Provide directives for maximum impact

2. Developer Review

Look at code quality from an engineer's perspective:

• Code Quality: Is code clean and maintainable?
• Standards: Does it follow coding conventions?
• Performance: Are there efficiency concerns?
• Scalability: Will it handle growth?
• Refactoring: Any code that needs improvement?
• Action: Suggest specific code improvements

3. Quality Engineer Review

Look at quality assurance from a testing angle:

• Test Coverage: Are all paths tested?
• Edge Cases: Are boundary conditions handled?
• Regression Risk: Could this break existing features?
• Test Quality: Are tests comprehensive and clear?
• Action: Identify missing tests and scenarios

4. Security Engineer Review

Look at potential risks from a security angle:

• Vulnerabilities: Any security risks?
• Data Handling: Is sensitive data protected?
• Authentication: Are auth checks proper?
• Input Validation: Is user input sanitized?
• Compliance: Does it meet security standards?
• Action: Flag security concerns immediately

5. DevOps Review

Look at deployment and monitoring from an ops angle:

• CI/CD Integration: Will builds succeed?
• Configuration: Are configs properly managed?
• Infrastructure: Any deployment concerns?
• Monitoring: Are metrics and logs adequate?
• Rollback: Can changes be safely reverted?
• Action: Ensure smooth deployment

6. UI/UX Designer Review

Look at the interface from a user experience angle:

• Visual Consistency: Does it match design system?
• Usability: Is it intuitive to use?
• Accessibility: Is it accessible to all users?
• Responsive: Does it work on all devices?
• Polish: Any rough edges to smooth?
• Action: Ensure delightful user experience

Review Process

Standardized review workflow:

1. Read PR description and linked issues

   • Understand the context and purpose of the change

2. Review code changes systematically

   • Go file by file, pay attention to context

3. Test functionality locally if applicable

   • Actually run it and verify

4. Consider each perspective above

   • Walk through each role's lens

5. Leave constructive feedback

   • Provide specific, actionable suggestions

6. Approve or request changes

   • Make a clear approval decision

Key Principle

Improvements scheduled for "later" must be addressed NOW!

Don't let "we'll fix it later" become a tech debt excuse.

Practical Tips

Review Checklist Template

## PR Review: [PR Title]

### Product Perspective

-   [ ] Business value delivered
-   [ ] Requirements met
-   [ ] User experience considered

### Developer Perspective

-   [ ] Code is clean and readable
-   [ ] Follows coding standards
-   [ ] No obvious performance issues

### QA Perspective

-   [ ] Test coverage adequate
-   [ ] Edge cases handled
-   [ ] No regression risks

### Security Perspective

-   [ ] No security vulnerabilities
-   [ ] Input properly validated
-   [ ] Sensitive data protected

### DevOps Perspective

-   [ ] CI/CD compatible
-   [ ] Monitoring in place
-   [ ] Rollback possible

### UX Perspective

-   [ ] Consistent with design system
-   [ ] Accessible
-   [ ] Responsive

Using AI to Help Review

You can have AI review code from different role perspectives:

Review this PR from the following roles:
1. Product Manager - focus on business value
2. Security Engineer - focus on security risks
3. QA Engineer - focus on test coverage

[Paste PR code or link]

Next Steps

Check out Code Analysis Options to learn more code quality analysis techniques.